GitHub user cfries opened a pull request:

    https://github.com/apache/zeppelin/pull/2305

    [ZEPPELIN-2382] Fixed windows compatibility of interpreter binding.

    ### What is this PR for?
    Fixing ZEPPELIN-2382:
    
    A fresh install of Zeppelin 0.7.1 failed to start on a Windows due to the 
use of 
[getPosixFilePermissions](https://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#getPosixFilePermissions(java.nio.file.Path,%20java.nio.file.LinkOption...))
    
    This method fails on Windows with an UnsupportedOperationException - 
however, recovering (that is ignoring the exception) appears to have no 
negative effects. (For a discussion on this related to a different project see, 
e.g., https://github.com/GoogleCloudPlatform/google-cloud-intellij/issues/937 )
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Have the binary distribution checked by the reporter of 
[ZEPPELIN-2382]
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2382
    
    ### How should this be tested?
    Check if clean distribution runs on Windows. Important: Ensure that 
HADOOP_HOME points to a folder containing bin/winutils.exe since this pull 
request does not include a fix for 
https://issues.apache.org/jira/browse/ZEPPELIN-2438 (which is part of a 
separate pull request).
    
    ### Screenshots (if appropriate)
    N/A
    
    ### Questions:
    * Does the licenses files need update?
    No
    
    * Is there breaking changes for older versions?
    No
    
    * Does this needs documentation?
    No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cfries/zeppelin 
windows-compatiblity-interpreter-binding

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2305.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2305
    
----
commit 3635ed8a717108ba82753413bd0500519ffd4add
Author: Christian Fries <em...@christian-fries.de>
Date:   2017-04-08T20:00:33Z

    [ZEPPELIN-2375]: Avoid modification of CLASSPATH variable.
    
    The script previously modified the CLASSPATH variable. This may lead to
    an undesired side effect, where the zeppelin server classpath is
    exported to the zeppelin interpreter classpath, see JIRA issue
    ZEPPELIN-2375 for details. Instead of modifying classpath we now work
    the other way around and set ZEPPELIN_CLASSPATH or
    ZEPPELIN_INT_CLASSPATH to include CLASSPATH and then use
    ZEPPELIN_CLASSPATH or ZEPPELIN_INT_CLASSPATH in the corresponding exec
    (runner), respectively.
    
    See also https://issues.apache.org/jira/browse/ZEPPELIN-2375

commit 096fed6cfde37051b95018cedd455db3084aa1c9
Author: Christian Fries <em...@christian-fries.de>
Date:   2017-04-27T16:38:53Z

    Merge branch 'master' into apache/master

commit e3b5738dd959a3fa7dc4d11073ef5e483377654d
Author: Christian Fries <em...@christian-fries.de>
Date:   2017-04-30T19:44:12Z

    Added graceful exception handling if posix permission is not available
    
    On Windows system the Files.setPosixFilePermissions will (currently)
    fail. For the case that the operation is not supported we just continue
    (keep finger crossed) (on windows the file apparently has the right
    permissions).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to