GitHub user paularmand opened a pull request:

    https://github.com/apache/zeppelin/pull/2282

    fix python interpreter as to use max result setting

    ### What is this PR for?
    zeppelin_python.py used a hard-coded 1000 rows limit when returning 
results. This PR makes sure that the interpreter retrieves the max_results from 
PythonInterpreter.java and that the latter retrieves this configuration from 
the configuration via the properties object.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2447
    
    ### How should this be tested?
    + use %python interpreter
    + make a dataframe with more than a 1000 rows
    + z.show the dataframe
    + export it in csv 
    + the numbers of rows should exceed 1000 rows
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    no
    * Is there breaking changes for older versions?
    no
    * Does this needs documentation?
    no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paularmand/zeppelin 
python_interpreter_max_results

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2282
    
----
commit 507c6e88ea2e0d5410cf02c20a177b8b0e93b2f6
Author: Paul-Armand Verhaegen <paularm...@paularmandsmbp.rto.be>
Date:   2017-04-25T08:10:19Z

    fix python interpreter as to use max result setting

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to