GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2263

    ZEPPELIN-2421. AngularObject miss AngularObjectListener when it is pushed 
from frontend

    
    ### What is this PR for?
    This bug happens when you save your note, and restart zeppelin and run it 
again. The root cause is that the angular object miss  AngularObjectListener 
which means you can not sync up the changes on angular object to frontend. This 
PR would restore the listener correctly when we restore the angular objects 
saved before.  Also make some changes for logging in this PR. 
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2421
    
    ### How should this be tested?
    Tested manually
    
    ### Screenshots (if appropriate)
    
    Before
    
![zeppelin_before](https://cloud.githubusercontent.com/assets/164491/25173268/0824dc72-2526-11e7-955c-ea5e20dae746.gif)
    
    
    After
    
![zeppelin_after](https://cloud.githubusercontent.com/assets/164491/25173272/09e11bfc-2526-11e7-9096-5adb6f1992ef.gif)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIn-2421

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2263
    
----
commit c2503a4608cca0429e89709fe0ad2aeaaf22bf26
Author: Jeff Zhang <[email protected]>
Date:   2017-04-19T09:26:21Z

    ZEPPELIN-2421. AngularObject miss AngularObjectListener when it is pushed 
from frontend

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to