[GitHub] zeppelin pull request #2225: [ZEPPELIN-2357] fix: tooltip doesnt work with b...

Wed, 05 Apr 2017 02:33:08 -0700 

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2225

    [ZEPPELIN-2357] fix: tooltip doesnt work with btngroup

    ### What is this PR for?
    
    tooltip provided by [angular-ui: 
bootstrap](https://github.com/angular-ui/bootstrap) doesn't work with 
`btn-group` class. 
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [x] - fixed tooltip issue by bumping version of angular-bootstrap
    * [x] - added tooltip to charts as like before 
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2357](https://issues.apache.org/jira/browse/ZEPPELIN-2357)
    
    ### How should this be tested?
    
    1. Open spark tutorial
    2. Test tooltips in notebook controller and in paragraphs.
    
    ### Screenshots (if appropriate)
    
    #### Before
    
    
![tooltip_before](https://cloud.githubusercontent.com/assets/4968473/24699102/dc76be40-1a2d-11e7-9ae3-b550a1739ca8.gif)
    
    
    #### After
    
    
![tooltip_after1](https://cloud.githubusercontent.com/assets/4968473/24699105/dfaa5716-1a2d-11e7-8d8a-0576fb307200.gif)
    
    
![tooltip_after2](https://cloud.githubusercontent.com/assets/4968473/24699111/e429454a-1a2d-11e7-97cc-09bd77dcc4ca.gif)
    
    ### Questions:
    * Does the licenses files need update? - YES, updated
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2357/tooltip-doesnt-work-with-btngroup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2225.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2225
    
----
commit 62784c81dfbe7958585cd69c0ef68060d88db991
Author: 1ambda <[email protected]>
Date:   2017-04-05T08:25:29Z

    fix: Bump up angular-bootstrap version

commit 1e2db4ebdc9072c35cc7d70cee44576e2438cf94
Author: 1ambda <[email protected]>
Date:   2017-04-05T08:27:02Z

    fix: Use uib-tooltip instead

commit 0b6ad26843b9f5114a7eae0f7da4ee4d47031217
Author: 1ambda <[email protected]>
Date:   2017-04-05T09:25:18Z

    feat: Tooltip for charts

commit d03a70e3b35511ae283a4ea430940095967eaf95
Author: 1ambda <[email protected]>
Date:   2017-04-05T09:29:00Z

    fix: bin license

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to