GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/2154

    [HOT FIX][MASTER] Fix multi dynamic select forms behaviour

    ### What is this PR for?
    After #2100 merged, we can control the behaviour of running select form 
using `Run on selection change` under each paragraph control menu. But 
currently if user creates multiple dynamic forms in one paragraph, the select 
form box itself[1] and `Run on selection` menu[2] don't appear  as reported in 
https://github.com/apache/zeppelin/pull/2141#issuecomment-287537706. 
    
     - [1]
    
![image](https://cloud.githubusercontent.com/assets/10060731/24073544/4b477ec2-0c3c-11e7-95ae-d651c0180903.png)
    
     - [2]
    
![image](https://cloud.githubusercontent.com/assets/10060731/24073550/5b91998e-0c3c-11e7-9418-797a5d26aa67.png)
     
    Regardless the number of select forms and the types of dynamic form, `Run 
on selection change` menu should be shown up if the paragraph has at least 1 
select form. 
    
    ### What type of PR is it?
    Bug Fix & Hot Fix
    
    ### What is the Jira issue?
    N/A
    
    ### How should this be tested?
    1. Create multiple select forms 
    ```
    %md 
    My first selection is ${my selection1=1,1|2|3}
    My second selection is ${my selection2=4,4|5|6}
    ```
    
    2. Create different types of dynamic form (e.g. 1 select form + 1 checkbox)
    ```
    %md
    
    My selection is ${my selection=1,1|2|3}
    My check list is ${checkbox:checkboxTest=list1|list2, 
list1|list2|list3|list4}
    
    ```
    
    There should be `Run on selection change` menu under the paragraph control 
menu in the above cases. And the select form should appear!
    
    ### Screenshots (if appropriate)
     - When multiple select forms are created
    
![double-selectforms](https://cloud.githubusercontent.com/assets/10060731/24073573/af12ae2c-0c3c-11e7-80fa-18abe98f2dfd.gif)
    
     - When different dynamic forms are created (e.g. 1 checkbox + 1 select 
form)
    
![checkbox_selectform](https://cloud.githubusercontent.com/assets/10060731/24073578/bce7af52-0c3c-11e7-85df-c858342f7e2e.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin 
fix/multiDynamicFormBehaviour

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2154
    
----
commit a9a8d3d672405448ea41bd69e9026034caf37b82
Author: RyuAhyoung <ahyoungryu@macbook-pro-5.local>
Date:   2017-03-18T15:07:27Z

    Fix multi dynamicforms behaviour

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to