GitHub user AhyoungRyu reopened a pull request:

    https://github.com/apache/zeppelin/pull/2100

    [ZEPPELIN-2060] Make dynamic select form turn on or off using checkbox

    ### What is this PR for?
    I added "Auto Run" checkbox for select dynamic form to make user turn on / 
off automatic running after the form value changed.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - update docs after getting feedback
    
    ### What is the Jira issue?
    [ZEPPELIN-2060](https://issues.apache.org/jira/browse/ZEPPELIN-2060)
    
    ### How should this be tested?
    1. Apply this patch and run Zeppelin web as dev mode
    ```bash
    # under zeppelin-web
    $ yarn run dev
    ```
    
    2. Go to Spark tutorial note and try to change value in select form as 
below screenshot imgs 
    
    ### Screenshots (if appropriate)
     - "Auto Run" checkbox button will be shown only in select dynamic form's 
dropdown menu
    
![record1](https://cloud.githubusercontent.com/assets/10060731/23608140/4d3ee016-02ab-11e7-8678-ed21f30a3e0e.gif)
    
     - _**turn on**_ "Auto Run"-> auto run right after the value changed / 
_**turn off**_ -> need to press `Enter`
    
![record2](https://cloud.githubusercontent.com/assets/10060731/23608142/4e950ed6-02ab-11e7-9035-fd6c3c40f501.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? yes, maybe [this 
part](https://github.com/apache/zeppelin/blob/master/docs/manual/dynamicform.md#select-form)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin feature/turnOnOrOffAutoRun

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2100
    
----
commit f2e32592ba3d7ba7b6073525a4d8cb908996e963
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2017-03-06T11:08:31Z

    Make dynamic select form turn on or off using checkbox

commit 507571199f8a545022c7500c0980bbdd90208bc0
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2017-03-06T13:10:14Z

    Add a space next to checkbox

commit 8a0ca30fd7340c621ed51a5f1a90782d65b130eb
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2017-03-14T13:53:06Z

    Change label to 'Run on selection change'

commit 66c6c21d1bb435f5ade327a8f68cf3e8897e1fb3
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2017-03-15T06:43:23Z

    Add test case for behaviour of 'Run on selection change'

commit 4904f38659453242e06bbaedab38b3c4427f20a4
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2017-03-15T07:06:07Z

    Update dynamicForm docs

commit 47dcb5f64a4079ea26c7a39f5ae3955a7a710d16
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2017-03-16T03:52:20Z

    Persist 'runOnSelectionChange' under note.json's config field

commit 40435794f8e64244dd602e1fbd986ffcf26a9400
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2017-03-16T09:12:26Z

    Add 'setting: {forms: {}}' info to paragraphMock

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to