GitHub user Leemoonsoo reopened a pull request:

    https://github.com/apache/zeppelin/pull/2137

    [ZEPPELIN-2260] Skip node,npm install and bundle when no helium package is 
selected

    ### What is this PR for?
    Zeppelin 0.7.0 installs node and npm when it first starts for Helium 
package.
    To be installed, or to failed to be installed due to network timeout, it 
takes some times.
    We can just create empty file when no Helium package is enabled, instead of 
install npm and build bundle.
    See discussion 
https://github.com/apache/zeppelin/pull/2095#issuecomment-285447619
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [x] - skip node,npm install and bundle package when no package is selected
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2260
    
    ### How should this be tested?
    When no package is selected (e.g. right after clean install Zeppelin), npm 
and node is no longer installed on startup.
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-2260

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2137
    
----
commit 520ad3f0eb2e17bdbf5413cfb3f55bcff181e749
Author: Lee moon soo <m...@apache.org>
Date:   2017-03-15T00:48:40Z

    Skip node,npm install and bundle when no helium package is selected

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to