GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/2133

    [ZEPPELIN-1357][Umbrella] Text overlap in the MultiBarChart

    ### What is this PR for?
    If using the `multiChartBar`, it often occurs overlap in text. So, this PR 
is for preventing to overlap in text. 
    
    The below is the case what I updated.
    1. The xLabel generally show all of the text without rotation (less than 
30).
    2. If the xLabel size is over than 30 and less than 80, the xLabel text are 
rotated as 90 degree and displayed.
    3. If the xLabel size is over than 80, the xLabel text are disappeared, but 
the tooltip is displayed.
    
    I have made improvements based on my thinking, so I would appreciate to 
give me your feedback.
    And if merged this PR, I'll update the feature so that user can use `min` 
and `max` variables by user on web.
    
    ### What type of PR is it?
    [Bug Fix | Improvement ]
    
    ### What is the Jira issue?
    * [ZEPPELIN-1357; UI - label wrapping not done properly in 
charts](https://issues.apache.org/jira/browse/ZEPPELIN/ZEPPELIN-1357)
    
    ### How should this be tested?
    1. Run the paragraph for bank data in  the `Basic Features (Spark)` 
notebook.
    2. Execute the following query.
    ``` 
    %sql
    select * from bank
    ```
    3. Use the pivot in the `Setting` toggle in the `MultiBarChart` such as the 
screenshots.
    
    ### Screenshots (if appropriate)
    **[Before]**
    
![z_zeppelin-1357_b](https://cloud.githubusercontent.com/assets/8110458/23898303/f80d7bbc-08f3-11e7-9b24-3248c492b8af.png)
    
    
![z_1357_b3_](https://cloud.githubusercontent.com/assets/8110458/23898435/75b3ae60-08f4-11e7-9d7c-31746f0d4edc.png)
    
    **[After]**
    
![z_1357_a](https://cloud.githubusercontent.com/assets/8110458/23898452/820c0ffe-08f4-11e7-900a-9e61d379a294.gif)
    
    
![z_1357_a2](https://cloud.githubusercontent.com/assets/8110458/23898454/84c039e6-08f4-11e7-8f1e-e0b85b690da2.gif)
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-1357_overlap_text

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2133
    
----
commit 5b1930e8b8023e4d037667f71514ca565e0773ea
Author: soralee <sora0...@zepl.com>
Date:   2017-03-14T05:07:44Z

    prevent to overlap in text if using multiBarChart

commit f342b72e328ac5b0fe4f91b9da38aa3cf7eb3bed
Author: soralee <sora0...@zepl.com>
Date:   2017-03-14T10:28:47Z

    prevent to overlap in text if using multiBarChart

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to