[GitHub] zeppelin pull request #2119: [ZEPPELIN-2243] Use uppercase for shortcut desc...

[1ambda]

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2119

    [ZEPPELIN-2243] Use uppercase for shortcut description

    ### What is this PR for?
    
    Use uppercase for keyboard shortcut description so that user can recognize 
shortcuts easily.
    it's hard to understand for some shortcuts since we used lowercases. For 
example, `Ctrl+Option+l` (actually this `L`, not `I`)
    
    I attached screenshots.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    NONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2243](https://issues.apache.org/jira/browse/ZEPPELIN-2243)
    
    ### How should this be tested?
    
    1. Open the paragraph shortcut panel.
    2. Open the note shortcut dialog.
    
    ### Screenshots (if appropriate)
    
    #### Before
    
    <img width="261" alt="before_2243" 
src="https://cloud.githubusercontent.com/assets/4968473/23786191/fb3dafe8-05ae-11e7-8e1e-36b5f151070f.png";>
    
    #### After
    
    <img width="263" alt="after_2243" 
src="https://cloud.githubusercontent.com/assets/4968473/23786194/fe59b1e0-05ae-11e7-9741-371f8e3f77de.png";>
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2243/use-uppercase-for-keyboard-shortcut-description

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2119
    
----
commit 42021da53093edcc699b69f1ad73355c9a215d2c
Author: 1ambda <1am...@gmail.com>
Date:   2017-03-10T07:24:12Z

    fix: Use uppercase for shortcut desc

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---