GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/2113

    [ZEPPELIN-2190] Support custom web development port

    ### What is this PR for?
    This PR is for support flexible port for custom `web application 
development` and update the structure of README.md document for the support 
variable.
    
    ### What type of PR is it?
    [ Improvement | Documentation (README.md) ]
    
    ### What is the Jira issue?
    * [ZEPPELIN-2190](https://issues.apache.org/jira/browse/ZEPPELIN-2190)
    
    ### How should this be tested?
    1. run build 
       - `mvn clean package -DskipTests -pl 'zeppelin-web'`
    2. run dev mode with `WEB_PORT` variable port under `zeppelin-web` folder 
       - `WEB_PORT=9999 yarn run dev`
    3. connect `localhost:9999` on web browser
    
    ### Screenshots (if appropriate)
    [after]
    
![image](https://cloud.githubusercontent.com/assets/8110458/23742014/86a34c3a-04ee-11e7-8e00-26b3d89f7bec.png)
    
    
![image](https://cloud.githubusercontent.com/assets/8110458/23742041/a71b2b7c-04ee-11e7-9159-8565fc63549c.png)
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes, README.md of `zeppelin-web`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-2190

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2113
    
----
commit 485941d61779c14345c8dea01004112b7de5e928
Author: soralee <sora0...@zepl.com>
Date:   2017-03-09T07:04:35Z

    Support custom web development port

commit 08fb5a708831f98e84ce1c7ea7cfc70ee53d1dd6
Author: soralee <sora0...@zepl.com>
Date:   2017-03-09T08:04:57Z

    add description (README.md, webpack.config.js)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to