GitHub user Remilito opened a pull request:

    https://github.com/apache/zeppelin/pull/2111

    [ZEPPELIN-2230] clear bower_contents if bower.json changed

    ### What is this PR for?
    Before travis build:
    * check if any bower.json file is part of the commit range
    * check if any commit message of the commit range contains "bower clear" or 
"clear bower"
    * If one of the above, clear bower_components, npm cache clear
    This should prevent breaking the build when upgrading a js lib.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    [ZEPPELIN-2230](https://issues.apache.org/jira/browse/ZEPPELIN-2230)
    
    ### How should this be tested?
    
    1. Using this version of .travis.yml, build the project once. (e.g. with 
nvd3 1.7.1)
    2. then modify a version of js lib (e.g. nvd3), rebuild.
    3. Verify the build goes through, check the build log for the message 
"Clearing bower_components cache".
    4. Rebuild, without changing a version, but putting "bower clean" in a 
commit message. 
    5. Same as 3.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Maybe for the "bower clear" trigger. 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-2230b

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2111
    
----
commit cb9647f10dc2879ec6a2e0ae338067bd1e919958
Author: Remilito <remy.ga...@gmail.com>
Date:   2017-03-07T17:32:12Z

    [ZEPPELIN-2230] clear bower_contents if bower.json changed or bower
    clear provided in commit message

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to