GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/2097

    [MINOR][ZEPPELIN-2154] Enable work in the web dev mode if changing default 
server port

    ### What is this PR for?
    If user change `zeppelin.server.port` variable in zeppelin-site.xml, 
zeppelin doesn't work in web development. 
    In order for user to run zeppelin correctly, so that user can add 
`SERVER_PORT` as an environment variable when running web application 
development mode.
    
    ### What type of PR is it?
    [Bug Fix | Improvement | Documentation]
    
    ### What is the Jira issue?
    * [ZEPPELIN-2154](https://issues.apache.org/jira/browse/ZEPPELIN-2154)
    
    ### How should this be tested?
    1. Change `zeppelin.server.port` from 8080 to 8888 (or another port) in 
`zeppelin-site.xml`
    2. Run zeppelin (`bin/zeppelin-daemon.sh start`)
    3. Run web development mode under `zeppelin-web` folder such like 
`SERVER_PORT=8888 yarn run dev` 
    4. Connect `localhost:9000`
    
    ### Screenshots (if appropriate)
    [Before]
    
![z_2130_before](https://cloud.githubusercontent.com/assets/8110458/23586226/37f38252-01d4-11e7-8261-37e4e17c7eaf.gif)
    
    [After]
    
![z_2130_after](https://cloud.githubusercontent.com/assets/8110458/23586227/3aa4422a-01d4-11e7-8cd0-c0644e315131.gif)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes, added in README.md


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-2154_port_webDevMode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2097.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2097
    
----
commit ce9c18e3bef120f99edd32a6fa8ac185cac1ebb9
Author: soralee <sora0...@zepl.com>
Date:   2017-03-05T09:08:30Z

    enable custom server port in web dev mode

commit 54f0a96d92f26236841ed0e5c9647abc54c8089d
Author: soralee <sora0...@zepl.com>
Date:   2017-03-05T10:11:12Z

    add README.md

commit 49128a832ac6e4b78c163b2977d6fa5624e9fce5
Author: soralee <sora0...@zepl.com>
Date:   2017-03-05T10:21:03Z

    add README.md

commit 6f2b8e4e99575d041fba0803f0e95a18d8e921d9
Author: soralee <sora0...@zepl.com>
Date:   2017-03-05T10:23:29Z

    modify typo

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to