GitHub user prabhjyotsingh reopened a pull request:

    https://github.com/apache/zeppelin/pull/2086

    [ZEPPELIN-2167] User with insufficient privileges can still restore files 
by renaming files in/out of Trash

    ### What is this PR for?
    User with insufficient privileges can still restore files by renaming files 
in/out of Trash
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * [ZEPPELIN-2167](https://issues.apache.org/jira/browse/ZEPPELIN-2167)
    
    ### How should this be tested?
    Steps to reproduce:
     - Create a notebook "test_nb" as bob.
     - Delete the notebook
     - Login as mary and try restoring "test_nb" from Trash folder. The system 
correctly complains of insufficient privileges.
     - Open the "test_nb" notebook from Trash folder. The notebook opens with 
title "~Trash/test_nb".
     - Edit the title and remove the prefix "~Trash".
    
    If you now look at the list of notebooks there is no file "test_nb" in 
Trash.
    Interestingly when you try and delete the recently moved file from Trash it 
complains that mary does not have privileges to delete it. Edit the title of 
that notebook to "~Trash/test_nb" and it goes back to Trash folder.
    
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2167

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2086.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2086
    
----
commit 07221e0e8e548d6316f6eba1390b51e477ee9115
Author: Prabhjyot Singh <prabhjyotsi...@gmail.com>
Date:   2017-03-01T13:58:39Z

    updateNoteName should use renameNote function

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to