GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2077

    [ZEPPELIN-2191] Helium package should be able to import css

    ### What is this PR for?
    
    Helium package should be able to import css. For example,
    
    - Someone want to create spell using jsoneditor 
(https://github.com/josdejong/jsoneditor/blob/master/docs/usage.md). In this 
case, he/she should import like this
    
    ```js
    import 'jsoneditor/dist/jsoneditor.min.css'
    import JSONEditor from 'jsoneditor/dist/jsoneditor.min.js'
    ```
    
    <br>
    
    **This PR is written based on #2071, so duplicated commit will be dropped. 
Please review the commit 505c7db only.**
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [x] - denote required packages in `package.json`
    * [x] - setup `webpack.config.js`
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2191](https://issues.apache.org/jira/browse/ZEPPELIN-2191)
    
    ### How should this be tested?
    
    Should be able to bundle 
[zeppelin-echo-spell](https://github.com/1ambda/zeppelin-json-spell)
    
    ### Screenshots (if appropriate)
    
    NONE
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2191/import-css-in-helium-pkg

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2077.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2077
    
----
commit 00a0afe12250db36290acb11d7e8f94aa30822bd
Author: 1ambda <1am...@gmail.com>
Date:   2017-02-27T02:35:38Z

    fix: Update babel configuration

commit 505c7dbb51a80253704c9fc0b29d2c2f154be378
Author: 1ambda <1am...@gmail.com>
Date:   2017-02-27T23:45:19Z

    fix: Import css globally in helium package

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to