GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/2072

    [ZEPPELIN-2060] Show tooltip msg after dynamic form value is changed

    ### What is this PR for? 
    As described in 
[ZEPPELIN-2060](https://issues.apache.org/jira/browse/ZEPPELIN-2060), the 
dynamic form's behaviour has been changed back and forth.
    In current status(nothing happened when user change the dynamic form 
value), I made this tooltip msg automatically shows up. This will be helpful to 
let users know they need to click run button or `Shift+Enter`. 
    
    ![screen shot 2017-02-27 at 2 58 16 
pm](https://cloud.githubusercontent.com/assets/10060731/23350345/41c2cf44-fcfd-11e6-883f-21b13aa84076.png)
    
    If there can be better way for this, please let me know :)
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - set timeout 
    
    ### What is the Jira issue?
    [ZEPPELIN-2060](https://issues.apache.org/jira/browse/ZEPPELIN-2060)
    
    ### How should this be tested?
    1. Apply this patch and run Zeppelin web as dev mode
    ```bash
    #under zeppelin-web
    $yarn run dev
    ```
    
    2. Go to Spark tutorial note and try to change value in dynamic forms as 
below screenshot imgs 
    
    
    ### Screenshots (if appropriate)
    After this change
    
![record](https://cloud.githubusercontent.com/assets/10060731/23350176/1350c75c-fcfc-11e6-8544-6556ec06abea.gif)
    
![record2](https://cloud.githubusercontent.com/assets/10060731/23350180/19ddd8b2-fcfc-11e6-864b-794a9dc583aa.gif)
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? yes?
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2060

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2072.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2072
    
----
commit 13218553aace1d08edeee086a23febf09654ee68
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2017-02-27T05:43:33Z

    Show tooltip msg after dynamic form value is changed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to