Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1582
Some build fail looks like oriented from flaky test.
Recently, a lot of flaky test has been fixed and i think it's better take
advantage of those fix by merge master to this branch.
By the way, i'm afraid to say this, but i suggest split this PR to small
pieces if you don't mind.
Because it adds/touches many places and review takes long time, and while
reviewing, current code base changes/adds new things and this branch change
code to resolve conflicts, that require more reviews and so on and so on.
For example, beginning of this pullrequest didn't have such things like
tabledata.js, but during the pullrequest, this branch had to change your code
because of tabledata.js and new visualization code. And this branch changed
tabledata.js to datasetfactory.js, which i'm about to review we can't change
this because tabledata.js is now part of visualization api. By the way, neo4j
interpreter is not related with all these stuff at all, but couldn't merged.
I'm feeling like we're going to repeat the same thing again and again. So
I'd suggest split this PR into 3 peaces.
a) Neo4j Interpreter
b) Visualization
c) Adding display type
I think a) and b) are modular, so i guess it's not going to be too
complicated to split it into 3 PR.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
