GitHub user sotnich opened a pull request:

    https://github.com/apache/zeppelin/pull/1828

    [ZEPPELIN-1876] smart psql autocomplition

    ### What is this PR for?
    This PR changes autocompletion behaviour in postgresql interpeter.
    There are some changes:
    * [main change] autocompletion now depends on what are you typing. Now 
there are four types of competion: schema, table, column and keywords. If you 
typing new word then autocompetion suggests only keywords and schema names. If 
you are typing after schema name with point then you get list of tables in that 
schema. Also if you typing a name after point after a table name you will get a 
list of column names of this table.
    * autocomption now supports aliases in sql. If you write alias for a table 
you will get a list of columns of an aliased table if you write down the alias 
and a point.
    * new option are availble for postgresql interpreter: 
postgresql.completer.schema.filter. It allows filter schema names loaded into 
autocompletion (no more garbage schema names).
    * autocompletion now load keywords only in low case (otherwise there are so 
many keywords in a list of autocompletion that it is becomes uncomfortable)
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - sort names in the output of autocompletion
    * [ ] - list only schema names if we are typing a schema name (for example 
after keywork FROM)
    * [ ] - add description in autocompletion list for schema names - schema, 
for table names - table and so
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1876
    
    ### How should this be tested?
    Outline the steps to test the PR here.
    
    ### Screenshots (if appropriate)
    https://issues.apache.org/jira/secure/attachment/12845228/auto1.JPG
    https://issues.apache.org/jira/secure/attachment/12845229/auto2.JPG
    https://issues.apache.org/jira/secure/attachment/12845230/auto3.JPG
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sotnich/zeppelin psql-1876

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1828.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1828
    
----
commit c33778f468174535e0345d2b3a64d592f89cdd60
Author: Sotnichenko Sergey <s.sotniche...@tinkoff.ru>
Date:   2016-12-31T17:33:27Z

    Main changes

commit 4e9d4dd65fc27bff6e58fe3ffebc653c116d4815
Author: Sotnichenko Sergey <s.sotniche...@tinkoff.ru>
Date:   2016-12-31T18:24:01Z

    [ZEPPELIN-1876] Main changes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to