GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1823
[ZEPPELIN-1850] Remove strip-loader (webpack)
### What is this PR for?
Removed [strip-loader](https://issues.apache.org/jira/browse/ZEPPELIN-1850)
which was added to remove `console.log` in production.
- It has a bug as you can see in below (screenshot section)
- Deleting it help us to keep the package list simple
- Also using the same configuration for uglify both in webpack and grunt
will ensure that vendor package have the consistent behavior when they are
managed by webpack
### What type of PR is it?
[Bug Fix | Improvement]
### Todos
Done at once
### What is the Jira issue?
[ZEPPELIN-1850](https://issues.apache.org/jira/browse/ZEPPELIN-1850)
### How should this be tested?
1. Add this code below in master branch and execute `npm run build` to lint
```
console.log('editor isn\'t loaded yet, returning..');
```
2. Test the same command and code within this branch. It will work.
### Screenshots (if appropriate)
```
ERROR in ./src/app/notebook/paragraph/paragraph.controller.js
Module build failed: SyntaxError: Unexpected token, expected , (197:8)
195 | }
196 | }
> 197 | });
| ^
198 | } else {
199 | BootstrapDialog.confirm({
200 | closable: true,
@ ./src/index.js 53:0-59
Child html-webpack-plugin for "index.html":
+ 1 hidden modules
Running "useminPrepare:html" (useminPrepare) task
Configuration changed for concat, uglify, cssmin
Running "concurrent:dist" (concurrent) task
Running "svgmin:dist" (svgmin) task
Total saved: 0 B
Done, without errors.
Execution Time (2016-12-30 06:21:32 UTC)
loading tasks 121ms
ââââââââââââââââââââââââââââââââââ
70%
svgmin:dist 51ms ââââââââââââââ 30%
Total 172ms
Running "copy:styles" (copy) task
Copied 17 files
Done, without errors.
Execution Time (2016-12-30 06:21:32 UTC)
loading tasks 127ms
âââââââââââââââââââââââââââââââââââââ
77%
copy:styles 38ms âââââââââââ 23%
Total 165ms
Running "postcss:dist" (postcss) task
>> 17 processed stylesheets created.
>> No "concat" targets found.
Warning: Task "concat" failed. Use --force to continue.
Aborted due to warnings.
Execution Time (2016-12-30 06:21:30 UTC)
loading tasks 117ms ââââ 6%
useminPrepare:html 22ms â 1%
concurrent:dist 1.5s
âââââââââââââââââââââââââââââââââââââââââââââââââââ
80%
postcss:dist 252ms âââââââââ 13%
Total 1.9s
npm ERR! Darwin 15.6.0
npm ERR! argv "/Users/lambda/.nvm/versions/node/v6.9.1/bin/node"
"/Users/lambda/.nvm/versions/node/v6.9.1/bin/npm" "run" "build"
```
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin
ZEPPELIN-1850/remove-strip-loader-in-webpack
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1823.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1823
----
commit 3d3a58176174c8889f248b4dab29625b7dc6e58a
Author: 1ambda <[email protected]>
Date: 2016-12-30T06:18:42Z
fix: Remove strip-loader to avoid single quote error
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
