GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/1821
[ZEPPELIN-1875] permission dialog code is not stable
### What is this PR for?
The code for the notification pop-up is not stable.
Sometime when response to slow for backend.
Then the permission box and the dialogue open together.
### What type of PR is it?
Bug Fix , Improvement
### Todos
- [x] changed method name (getBlockNotAuthenticatedUserErrorMsg)
- [x] permission dialog pop-up change logic.
- [x] added check logic for anonymous user in checkIfUserIsAnon method
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1875
### How should this be tested?
1. when you do have turn on the shiro and login and click to note
permission button.
2. or turn off the shiro.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-PERMMIT-FIX
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1821.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1821
----
commit 4248c0b590986e59891f4289df93237a9b4284da
Author: cloverhearts <cloverhearts...@gmail.com>
Date: 2016-12-29T07:55:08Z
refix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
