Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1783
  
    @PetroKostyuk Thanks for your contribution! It's really useful feature 
indeed. 
    For the quick review, it would be better to edit PR title to sth like 
"[ZEPPELIN-727] Enable to jump to specific paragraph using anchor" instead of 
just "ZEPPELIN 727". Then other ppl can recognize what this PR implemented at a 
glance.
    
    I tested and it works well as you described. Here are some my thoughts 
    
    1. In my case, couldn't get the difference between ![screen shot 2016-12-20 
at 11 54 50 
am](https://cloud.githubusercontent.com/assets/10060731/21336801/26e2b028-c6ab-11e6-983f-fe2a4ad40d6a.png)
     and ![screen shot 2016-12-20 at 11 54 16 
am](https://cloud.githubusercontent.com/assets/10060731/21336782/13ac1558-c6ab-11e6-8469-7bf25f557043.png)
 at the first time. Probably some users will be same with me. I know "Link this 
paragraph" is existed one, but "Publish this paragraph with iframe" instead of 
"Link this paragraph" would be more precise to prevent any confusion.
    
    2. With this PR, we need to 
    Click gear icon -> Click "Link to paragraph in context" menu  -> Ctrl+C and 
enter to copy the paragraph url -> Open new tab -> Paste the url 
    
    IMPO using anchor has to be simple. Let's say we need specific paragraph 
url to give this location to someone. e.g. in Zeppelin official docs site,
    
![anchor](https://cloud.githubusercontent.com/assets/10060731/21336999/c9d913b6-c6ac-11e6-8a1e-eda656f379f9.gif)
    
    The icon is exposed in the outside(need mouse hovering) and we can 
instinctively recognize what it is. 
    
    So i think it would be better the anchor icon can be exposed in the outside 
not in the dropdown menu. And after we click that icon, the url will be exposed 
in the top header bar like I posted in the above, or maybe automatically copied 
right after we click it (please refer to #1750 ).
    
    It's just my opinion in my head. So please take with grain of salt and feel 
free to share your thought! :D
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to