GitHub user cuspymd opened a pull request:
https://github.com/apache/zeppelin/pull/1770
[ZEPPELIN-1763] Prevent duplicate $scope.$on('setNoteMenu') calls
### What is this PR for?
It's to fix the issue 'ZEPPELIN-1763' (Zeppelin hangs if I repeatedly
select and deselect note name).
When the note name was changed, there was a problem that the 'setNoteName'
listener was registered in duplicate and occupied resources.
To fix it, I moved the function that registers the listener out of
initNoteBook()
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
[ZEPPELIN-1763](https://issues.apache.org/jira/browse/ZEPPELIN-1763?filter=-2)
### How should this be tested?
Repeat changing note name.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
The listners are added in duplicate on $scope.$on('setNoteMenu') calls.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cuspymd/zeppelin note-name-pr2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1770.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1770
----
commit 99a10314917c2db4a0d88a1efe7780a863d12cee
Author: Myoungdo Park <cusp...@gmail.com>
Date: 2016-12-15T13:31:23Z
Prevent duplicate $scope.$on('setNoteMenu') calls
The listners are added in duplicate on $scope.$on('setNoteMenu') calls.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
