[GitHub] zeppelin pull request #1752: [HOT FIX] Fix broken display_formula.png by usi...

[AhyoungRyu]

GitHub user AhyoungRyu reopened a pull request:

    https://github.com/apache/zeppelin/pull/1752

    [HOT FIX] Fix broken display_formula.png by using relative path

    ### What is this PR for?
    Currently `display_formula.png` (added by #1606) is broken in here: 
http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/displaysystem/basicdisplaysystem.html#mathematical-expressions
    
    Fixed it by using relative path for the image. But have no idea why the 
other image files are not broken in that page. 
    
    ### What type of PR is it?
    Documentation | Hot Fix
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    N/A
    
    ### How should this be tested?
    It can't be reproduced using docs dev mode. Needs to be tested with below 
steps. 
    
    ```
    1) build gh-pages (website) branch
    JEKYLL_ENV=production bundle exec jekyll build
    cp -r _site/ /tmp/zeppelin_website/
    mkdir -p /tmp/zeppelin_website/docs/0.7.0-SNAPSHOT
    
    2) build this patch (docs) and copy it under docs/0.7.0-SNAPSHOT of website
    cd docs
    bundle exec jekyll build --safe
    cp -r _site/ /tmp/zeppelin_website/0.7.0-SNAPSHOT/
    
    3) start httpserver and browse http://localhost:8000/docs/0.7.0-SNAPSHOT/
    cd /tmp/zeppelin_website
    python -m SimpleHTTPServer
    ```
    
    ### Screenshots (if appropriate)
    **Before**
     - In the official website 
    <img width="938" alt="screen shot 2016-12-13 at 7 07 27 pm" 
src="https://cloud.githubusercontent.com/assets/10060731/21136061/72c230b6-c167-11e6-9805-12d6f11f3270.png";>
    
    ```
    GET 
http://zeppelin.apache.org/assets/themes/zeppelin/img/screenshots/display_formula.png
 404 (Not Found)
    ```
    
    **After**
     - test locally using same with production path
    <img width="877" alt="screen shot 2016-12-13 at 7 09 42 pm" 
src="https://cloud.githubusercontent.com/assets/10060731/21136136/bbff660e-c167-11e6-9ed3-384e609886fe.png";>
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin fix-img-path

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1752.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1752
    
----
commit 4be330bfd50fd5ae15be6f79337a77e457fea28e
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2016-12-13T10:01:21Z

    Fix broken display_formula.png by using relative path

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---