[GitHub] zeppelin pull request #1691: ZEPPELIN-1716. Error of interpreter not found i...

[zjffdu]

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/1691

    ZEPPELIN-1716. Error of interpreter not found is not propagated to fr…

    ### What is this PR for?
    It is introduced in ZEPPELIN-1399, we call 
`InterpreterFactory.getInterpreter` before calling `Paragraph.jobRun`. This PR 
would ignore the `InterpreterException` in `Paragraph.isValidIntepreter`
    
    
    ### What type of PR is it?
    [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1716
    
    ### How should this be tested?
    Tested manually, see the following screenshot
    
    ### Screenshots (if appropriate)
    
    Before this PR, only see the following error in log, but not in frontend
    ```
    ERROR [2016-11-28 15:16:47,378] ({qtp1471868639-17} 
NotebookServer.java[onMessage]:303) - Can't handle message
    org.apache.zeppelin.interpreter.InterpreterException: spark.sparkr 
interpreter not found
        at 
org.apache.zeppelin.interpreter.InterpreterFactory.getInterpreter(InterpreterFactory.java:1302)
        at 
org.apache.zeppelin.notebook.Paragraph.isValidInterpreter(Paragraph.java:596)
        at org.apache.zeppelin.notebook.Paragraph.getMagic(Paragraph.java:586)
        at 
org.apache.zeppelin.socket.NotebookServer.runParagraph(NotebookServer.java:1337)
        at 
org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:226)
        at 
org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:59)
    ```
    After this PR
    
![2016-11-28_1514](https://cloud.githubusercontent.com/assets/164491/20659318/e8d00a58-b57d-11e6-854d-899614c4ca87.png)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    …ontend.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1716

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1691.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1691
    
----
commit ad7ec6373ec2d810cde24f6f47ebd24723d2733f
Author: Jeff Zhang <zjf...@apache.org>
Date:   2016-11-28T07:03:22Z

    ZEPPELIN-1716. Error of interpreter not found is not propagated to frontend.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---