GitHub user tae-jun opened a pull request:

    https://github.com/apache/zeppelin/pull/1676

    [ZEPPELIN-1705] Exclude unnecessary source file when check style on scio

    ### What is this PR for?
    When building Zeppelin with `mvn clean package install -DskipTests 
-DskipRat`, it fails on `scio` with an error log below:
    ```sh
    [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-checkstyle-plugin:2.13:check 
(checkstyle-fail-build) on project zeppelin-scio_2.10: You have 51 Checkstyle 
violations. -> [Help 1]
    ```
    This is because of **style check on a generated source**, which is exactly 
`$ZEPPELIN_HOME/scio/target/generated-sources/avro/org/apache/zeppelin/scio/avro/Account.java`
    
    This PR will make style check excludes the generated source.
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-1705](https://issues.apache.org/jira/browse/ZEPPELIN-1705)
    
    ### How should this be tested?
    Run `mvn clean package install -DskipTests -DskipRat`. It should print 
`BUILD SUCCESS`
    
    ### Questions:
    * Does the licenses files need update? NO
    * Is there breaking changes for older versions? NO
    * Does this needs documentation? NO
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1705

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1676.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1676
    
----
commit 2c1c56be603da91da2a7a3d29fd0d89e1163851f
Author: Jun <i2r....@gmail.com>
Date:   2016-11-24T11:37:19Z

    Exclude unnecessary source file when check style on scio

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to