GitHub user cloverhearts opened a pull request:

    https://github.com/apache/zeppelin/pull/1650

    [ZEPPELIN-1679] Invalid thrift implementation (developer critical)

    ### What is this PR for?
    
    Recently, zeppelin added some amazing features. 
    https://github.com/apache/zeppelin/pull/1613 
    You can easily access spark ui from the zeppelin web.
    However, in the implementation of the function, the Thrift interface seems 
to have arbitrarily modified the automatically generated code.
    So if you recreate the Thift interface by calling genthrift.sh.
    Zeppelin is not built.
    I modified this to get the same result with auto-generated code.
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    - [x] add event META_INFOS in RemoteInterpreterService.thrift
    - [x] import generate code 
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1679
    
    ### How should this be tested?
    1. First you need to install thift 0.9.2.
    2. Run zeppelin-interpreter / src / main / thrift / generate_thrift.sh.
    3. Build full zeppelin.
    4. After build, please check the interpreter spark setting in our web ui.
    5. Try using the spark ui button.
    
    If everything is running normally, it is a success.
    Problems occur in the current master 3.
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin fix-thift

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1650.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1650
    
----
commit ebd2838346ce2cf92b59ad0be7b9bddc001bd272
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2016-11-17T08:54:34Z

    fixed incorrect thrift implementation.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to