[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

[tae-jun]

Github user tae-jun commented on the issue:

    https://github.com/apache/zeppelin/pull/1567
  
    I also tested and was able to reproduce screenshot above.
    
    When I was another user, it returned `403` status code with message: 
    ```json
    {"status":"FORBIDDEN","message":"Insufficient privileges you cannot get 
this note"}
    ```
    
    However, when I didn't log in (i.e. anonymous), the browser(Chrome) 
redirected me to `http://localhost:8080/api/login` and returned `405` status 
code without any message. Users can be confused when there is no error message. 
And I think `403` status code is more proper since it's `forbidden`, not 
`method not allowed`.
    
    So in my opinion, it would be better:
    - Send `403` status code with some messages when a user is not logged in. 
Maybe something like:
    ```json
    {"status":"FORBIDDEN","message":"Please log in"}
    ```
    
    This is a miracle feature, by the way 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---