GitHub user vensant reopened a pull request:

    https://github.com/apache/zeppelin/pull/1430

    [ZEPPELIN-868] Notebook import fails when notebook is large

    ### What is this PR for?
    A bug fix: Added validation in the note import dialog box to check for the 
uploaded json file size and throw error report if the file size exceeds 1MB, as 
the websocket frame is not able to send json file of size over 1MB.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    NA
    
    ### What is the Jira issue?
    
    https://issues.apache.org/jira/browse/ZEPPELIN-868
    
    ### How should this be tested?
    1. Deploy Zeppelin and click on 'Import Note' in the Welcome to Zeppelin 
page.
    2. Click 'Choose a JSON here' and upload a json file whose file size is 
over 1MB
    
    ### Screenshots (if appropriate)
    
![1](https://cloud.githubusercontent.com/assets/12062069/18556899/7add7a12-7b8a-11e6-85e6-f8b4fcef2195.png)
    
![2](https://cloud.githubusercontent.com/assets/12062069/18556966/b10bcb0c-7b8a-11e6-9448-1381d8e05d8f.png)
    
![3](https://cloud.githubusercontent.com/assets/12062069/18556999/d166b8a8-7b8a-11e6-927b-caa3a56618d1.png)
    
![4](https://cloud.githubusercontent.com/assets/12062069/18557002/d58f8d74-7b8a-11e6-8955-710eb093a795.png)
    
    ### Questions:
    * Does the licenses files need update? NO
    * Is there breaking changes for older versions? NO
    * Does this needs documentation? NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vensant/zeppelin ZEPPELIN-868

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1430.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1430
    
----
commit 77a0cc1cd1ae43f53d2d20898e1a0e65e8d7be29
Author: vensant <venkatramana...@imaginea.com>
Date:   2016-09-15T14:38:47Z

    Added validation in the note import dialog box to check for the uploaded 
json file size as the websocket frame is not able to send file of size over 1MB

commit e48aac6d5a94ba2e21c1a3fd3f78bea68cb004e3
Author: vensant <venkatramana...@imaginea.com>
Date:   2016-09-16T06:06:30Z

    Rectified the errors due to grunt build no color failure

commit 5dcdcfe85506c42baa3224b87fc4f027fb448467
Author: vensant <venkatramana...@imaginea.com>
Date:   2016-09-22T06:29:58Z

    made changes for reading the max limit from the configuration list and 
dynamically showing it in UI

commit c65f2c7adf4f526506480f8aa5edcc03fb6f7783
Author: vensant <venkatramana...@imaginea.com>
Date:   2016-09-27T06:37:12Z

    client level validation added for import file size check

commit bd1acc088f1b9cf60f0ebac21b4a9289adb82728
Author: vensant <venkatramana...@imaginea.com>
Date:   2016-09-29T06:12:23Z

    fixed the review comments on the pull request

commit 29ad4cee20334bf3fa0cdd37211ca412a1e638ec
Author: vensant <venkatramana...@imaginea.com>
Date:   2016-09-29T07:27:43Z

    committed the code which missed during rebase

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to