GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1392
[ZEPPELIN-1437] Multi-user note management - user aware reload broadcast
### What is this PR for?
This PR addresses part of multi-user note management in Zeppelin. One of
the tasks namely listing notes per user on Zeppelin start was addressed in
#1330. However that PR didn't solve all problems, and reloading notes was
incomplete as well as socket broadcast was not user aware
[ZEPPELIN-1437](https://issues.apache.org/jira/browse/ZEPPELIN-1437),
[ZEPPELIN-1438](https://issues.apache.org/jira/browse/ZEPPELIN-1438). This PR
addresses those issue.
### What type of PR is it?
Improvement
### Todos
* [x] - list notes per user on reload
* [x] - broadcast per user (multicast)
* [x] - tests
* [x] - use authorization module to filter notes on sync
* [ ] - discussion and review
### What is the Jira issue?
[Zeppelin-1437](https://issues.apache.org/jira/browse/ZEPPELIN-1437),
[ZEPPELIN-1438](https://issues.apache.org/jira/browse/ZEPPELIN-1438)
### How should this be tested?
1. Start Zeppelin
2. Login as user1, and user2 on different windows
3. Each user should be able to see their own note workbench
4. If note changed to private (readers, writers not empty), that note
should disappear from others note workbench.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin
feat/multi-user-notes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1392.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1392
----
commit 17e2d4c0c5e5528031b36218339305300a69a543
Author: Khalid Huseynov <khalid...@gmail.com>
Date: 2016-09-01T07:29:57Z
first draft
commit b7f19c918b015867aefce5bd5b3a08fd65d720ff
Author: Khalid Huseynov <khalid...@gmail.com>
Date: 2016-09-17T06:11:40Z
separate getAllNotes() and getAllNotes(subject)
commit 92f37f50c3205d1a231693131d25e31b339d9deb
Author: Khalid Huseynov <khalid...@gmail.com>
Date: 2016-09-17T07:36:02Z
substitute old getAllNotes(subject) with new implementation
commit d9c3bc98cb799526d343ac7151877089de5d2f54
Author: Khalid Huseynov <khalid...@gmail.com>
Date: 2016-09-17T08:22:48Z
filter reload using predicates
commit 139940743f73692c4e3febff56a342960dd80185
Author: Khalid Huseynov <khalid...@gmail.com>
Date: 2016-09-19T00:23:43Z
remove unused imports
commit 09e67234821823f1e5cf2f4acf2329b36abdbed9
Author: Khalid Huseynov <khalid...@gmail.com>
Date: 2016-09-19T05:46:06Z
notebookAuthorization as singleton
commit 537cc0ebadac7bce9a9eb00fe76cd3d8da17f220
Author: Khalid Huseynov <khalid...@gmail.com>
Date: 2016-09-19T16:21:03Z
apply filter from authorization in sync
that's to sync only user workbench notes
commit 6614e2bb5224a4f408473cf0cbbd1f5fcb5b119c
Author: Khalid Huseynov <khalid...@gmail.com>
Date: 2016-09-20T04:14:13Z
improve tests
commit 9427e6260ab66665ed3cf8a606152f5361d7ec79
Author: Khalid Huseynov <khalid...@gmail.com>
Date: 2016-09-20T10:04:25Z
multicast fine grained note lists to users instead of broadcast
commit 781207e15b44dd90506910e8eceab2f805250a15
Author: Khalid Huseynov <khalid...@gmail.com>
Date: 2016-09-20T16:25:55Z
bugfix: reload only once
commit 17eae84c0c259c6181df2ac49a63349adced2ed7
Author: Khalid Huseynov <khalid...@gmail.com>
Date: 2016-09-21T04:20:13Z
bugfix: add precondition for NP
commit 9cf1d8848ee02b5fafda1afd538b71befd3eb412
Author: Khalid Huseynov <khalid...@gmail.com>
Date: 2016-09-23T09:13:51Z
fix init not to initialize every time
commit 094de2e61f7f341b0b7699f7b2f10fafc87ee29f
Author: Khalid Huseynov <khalid...@gmail.com>
Date: 2016-09-27T03:56:29Z
broadcast note list on perm update - zeppelin-1438
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
