Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1439
@Leemoonsoo Thanks for the feedback.
Indeed I think your first point on the Experimental annotation made sense,
so I have changed it.
As for your second point, I am not really sure how to best go about it
myself. When I first created the JIRA issue, I came up with a quick
implementation that used kept separate registries for each `Interpreter`
instance. It was certainly simpler, but the main problem that I ran into was
that I couldn't figure out how to make sure those changes in the registry
entered by the user were broadcasted to the ZeppelinServer side. I studied the
implementation of `AngularObjectRegistry` in order to understand how this could
be done in Zeppelin, and that is ultimately what led me to this current
implementation which uses thrift. I am still in the process of learning the
core Zeppelin codebase, so if you had any specific ideas, I would appreciate
it.
Also, can you also be specific on how this change would make it possible to
pass actual references to functions instead of code strings (hence why I used
put "callbacks" in quotes in the original PR)? I don't consider this to be too
important but am just curious.
Finally, can you provide some insight for some of the odd CI build failures
I have been experiencing with more recent commits?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
