Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1304
  
    @bzz 
    
    The front-end needs to be able to get the Notebook's revision and show it. 
To do that, there is a websocket event that originally looked like that: 
`websocketMsgSrv.getNoteRevision($routeParams.noteId, $routeParams.revisionId);`
    
    After using it, it seemed that this websocket event was not well defined on 
front-end side and that instead of `revisionId` I should be sending the whole 
revision description object to the backend.
    
    Which look like that:
    ```
    revision: {
    timestamp,
    text,
    revisionId
    }
    ```
    
    Now, unless there is a whole object to save, there should not be any reason 
for the front-end to send a full object to the back-end so that it can 
understand which revision I want. That's precisely what revisionId should be 
for, especially if I want to have a custom URL that allows loading that 
revision.
    
    Furthermore, in order for me to send a full revision description object, it 
would mean that I need to get the list of Revisions before I'm able to make any 
call to load the Notebook revision.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to