GitHub user beriaanirudh opened a pull request:

    https://github.com/apache/zeppelin/pull/1283

    Buffer append output results + fix extra incorrect results

    ### What is this PR for?
    On a paragraph run, for every line of output, there is a broadcast of the 
new line from zeppelin. In case of thousands of lines of output, the browser/s 
would hang because of the volume of these append-output events. Also, a bug has 
been observed where in such large output cases, the result will repeated 
(coming from append-output calls + finish-event calls).
    
    ### What type of PR is it?
    Improvement + Bug Fix
    
    ### Todos
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1292
    
    ### How should this be tested?
    The test could be to run a simple paragraph with large result. Eg:
    ```
    %sh
    for i in {1..10000}
    do
    echo $i
    done
    ```
    PS: One will need to clear browser cache between running with and without 
this code patch since there are javascript changes as well. 
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    No
    * Is there breaking changes for older versions?
    No
    * Does this needs documentation?
    It could need for the design. Otherwise I have added code comments 
explaining behaviour.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/beriaanirudh/zeppelin ZEPPELIN-1292

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1283
    
----
commit 7020f0cd053a39a60bb8f58ca5f701baadfae78d
Author: Beria <be...@qubole.com>
Date:   2016-08-04T12:15:36Z

    Buffer append output results + fix extra incorrect results

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to