GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1188
[ZEPPELIN-1183] Replace $window.location by $location
### What is this PR for?
There is a native service used across the app to take care of re-routing to
different page: `$location`, however there has been a few times where
`$window.location` is used instead, and people tend to do it in new PR too.
This convert the `$window.location` from the code to use `$location`.
Only one was kept in `app.controller.js` for Iframe, so it doesn't flicker.
### What type of PR is it?
Refactoring
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1183
### How should this be tested?
You can try to reproduce the couple of cases that redirection is needed,
but overall there shouldn't be any issue from that change.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1183
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1188
----
commit 60cd3271e9edcfb4d099cda34fcf7573be5f1837
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-07-15T03:42:01Z
Remove the window.location from the code, for
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
