Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
Great contribution, thank you!
Couple of questions on top of few one already raised above:
- will you be willing to add some tests as well? Looking at other
interpreters impl like #1164 one can see how to test I.e syntax errors and
other conditions, etc
- would it be hard or do you have plans to implement `cancel` and
`getProgress` as part of this contribution? They are very usefull in case of
big queries and improve user experience a lot on UI
- in current code, you use static interpreter registration mechanism,
which is now [deprecated](https://issues.apache.org/jira/browse/ZEPPELIN-804)
and all interpreters are in the process of migration. While we are here, in
order not to create one more migration sub-tesk for later, could you please
switch to `interpreter-settings.json` one instead? Its a dime change, here is
an example of how it is done for another interpreter #1063
- every interpreter and it's supported/unsupported features and
cobfiguration options are usually documented under `/docs/` which becomes part
of the
[website](http://zeppelin.apache.org/docs/0.6.0/development/howtocontributewebsite.html).
Would you care to document this one as well?
- for every new library introduced by this module, which Jar will end up
in the release convenience binary (all, with default scope) we need to have a
record in
`https://github.com/apache/zeppelin/blob/master/zeppelin-distribution/src/bin_license/LICENSE`
specifying it's license
Feel free to ask here, if something is not clearly or in case you have any
further questions!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
