GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/1080
[ZEPPELIN-1060] validate user before saving
### What is this PR for?
Zeppelin notebook permissions change has an issue while reconfiguring
permissions by clearing textbox
### What type of PR is it?
[Bug Fix]
### Todos
* [x] - Validate user list before saving
* [x] - getPermissions from server again before showing popup
### What is the Jira issue?
* [ZEPPELIN-1060](https://issues.apache.org/jira/browse/ZEPPELIN-1060)
### How should this be tested?
1) I log in as user 'admin'
2) I create a notebook 'Untitled Notebbok 1' as user admin
3) I setup permissions of the notebook as owners = admin, readers= admin,
writers= admin and click save button
It works file
4) Now I again try to give owners permission to 'All users' by clearing
owners field. Since in step-3 owners = admin ; it allows me to save these
changes successfully
5) Now I again try to toggle permissions of the notebook. Since in step-4 I
cleared owners field, it should allow all users to change permissions. But it
is not happening, instead it gives an error box that only User = [] has
sufficient permissions
### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1060
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1080.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1080
----
commit f735133de90c39a6d3a517ccc87e761cf6fe4066
Author: Prabhjyot Singh <prabhjyotsi...@gmail.com>
Date: 2016-06-24T16:32:11Z
validate user before saving
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
