GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/1055

    [ZEPPELIN-1028] Fix exported notebook importing error

    ### What is this PR for?
    
    This bug seems to be produced by #862. Currently a exported notebook is not 
imported with below error message.
    
    ```
    ERROR [2016-06-20 17:19:21,797] ({qtp559670971-14} 
NotebookServer.java[onMessage]:231) - Can't handle message
    com.google.gson.JsonSyntaxException: 2016-06-20T14:33:31-0700
        at 
com.google.gson.internal.bind.DateTypeAdapter.deserializeToDate(DateTypeAdapter.java:81)
        at 
com.google.gson.internal.bind.DateTypeAdapter.read(DateTypeAdapter.java:66)
        at 
com.google.gson.internal.bind.DateTypeAdapter.read(DateTypeAdapter.java:41)
        at 
com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:93)
        at 
com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:172)
        at 
com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40)
        at 
com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:81)
        at 
com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:60)
        at 
com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:93)
        at 
com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:172)
        at com.google.gson.Gson.fromJson(Gson.java:791)
        at org.apache.zeppelin.notebook.Notebook.importNote(Notebook.java:199)
        at 
org.apache.zeppelin.socket.NotebookServer.importNote(NotebookServer.java:656)
        at 
org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:175)
        at 
org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:56)
        at 
org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:128)
        at 
org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69)
        at 
org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65)
        at 
org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextFrame(JettyListenerEventDriver.java:122)
        at 
org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161)
        at 
org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309)
        at 
org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214)
        at 
org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220)
        at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258)
        at 
org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632)
        at 
org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480)
        at 
org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
        at 
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
        at 
org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
        at java.lang.Thread.run(Thread.java:745)
    Caused by: java.text.ParseException: Unparseable date: 
"2016-06-20T14:33:31-0700"
        at java.text.DateFormat.parse(DateFormat.java:366)
        at 
com.google.gson.internal.bind.DateTypeAdapter.deserializeToDate(DateTypeAdapter.java:79)
    ```
    This PR is only for exported notebook. So it should be tested after #1043 
merged.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [ ] - Merge with master after #1043 merged
    
    ### What is the Jira issue?
    [ZEPPELIN-1028](https://issues.apache.org/jira/browse/ZEPPELIN-1028)
    
    ### How should this be tested?
    1. Apply this patch (Build the source and restart Zeppelin)
    2. Export a notebook and try to import it again
    3. It should be imported as before
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-1028

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1055.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1055
    
----
commit f78fab9e699b5641704dafda9b7e9873773a3cc3
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2016-06-21T00:39:42Z

    Fix exported notebook importing error

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to