[GitHub] zeppelin pull request #1051: increase more logs, and return appropriate erro...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/1051

    increase more logs, and return appropriate error to front-end

    ### What is this PR for?
    In the current implementation JDBC interpret only catches SQLException and 
ClassNotFoundException. However, there can be a case for example 
NullPointerException or for that matter anything else can be thrown.
    
    
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [x] - increase more logs, and return appropriate error to front-end
    
    ### What is the Jira issue?
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
    * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. 
[ZEPPELIN-533]
    
    ### How should this be tested?
    As an example for hive2.
    
    #### Properties
    
    |name|      value|
    | ------------- |:-------------:|
    |default.driver|    org.apache.hive.jdbc.HiveDriver|
    |default.url        
|jdbc:hive2://hive-machine:2181/;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=hiveserver2|
    
    #### Dependencies
    
    |artifact   |exclude|
    | ------------- |:-------------:|
    |org.apache.hive:hive-jdbc:1.2.1    ||
    |org.apache.hadoop:hadoop-common:2.7.2||
    
    
    With the above setting used on an older driver for hive2 it shows exception 
in log, but on the front-end paragraph shows error, and no logs.
    
    ```
    ERROR [2016-06-19 14:47:46,186] ({pool-2-thread-2} Job.java[run]:182) - Job 
failed
    java.lang.NullPointerException
            at org.apache.thrift.transport.TSocket.open(TSocket.java:168)
            at 
org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:248)
            at 
org.apache.thrift.transport.TSaslClientTransport.open(TSaslClientTransport.java:37)
            at 
org.apache.hive.jdbc.HiveConnection.openTransport(HiveConnection.java:190)
            at 
org.apache.hive.jdbc.HiveConnection.<init>(HiveConnection.java:163)
            at org.apache.hive.jdbc.HiveDriver.connect(HiveDriver.java:105)
            at java.sql.DriverManager.getConnection(DriverManager.java:571)
            at java.sql.DriverManager.getConnection(DriverManager.java:187)
            at 
org.apache.zeppelin.jdbc.JDBCInterpreter.getConnection(JDBCInterpreter.java:218)
            at 
org.apache.zeppelin.jdbc.JDBCInterpreter.getStatement(JDBCInterpreter.java:229)
            at 
org.apache.zeppelin.jdbc.JDBCInterpreter.executeSql(JDBCInterpreter.java:288)
            at 
org.apache.zeppelin.jdbc.JDBCInterpreter.interpret(JDBCInterpreter.java:393)
            at 
org.apache.zeppelin.interpreter.LazyOpenInterpreter.interpret(LazyOpenInterpreter.java:94)
            at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:341)
            at org.apache.zeppelin.scheduler.Job.run(Job.java:176)
            at 
org.apache.zeppelin.scheduler.FIFOScheduler$1.run(FIFOScheduler.java:139)
            at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
            at java.util.concurrent.FutureTask.run(FutureTask.java:262)
            at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
            at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
            at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
            at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
            at java.lang.Thread.run(Thread.java:745)
    ```
    
    ### Screenshots (if appropriate)
    
    Before:
    <img width="1436" alt="screen shot 2016-06-20 at 5 11 59 pm" 
src="https://cloud.githubusercontent.com/assets/674497/16192988/20ce0312-370a-11e6-967e-281e99dbb18f.png";>
    
    
    After:
    <img width="1435" alt="screen shot 2016-06-20 at 5 10 26 pm" 
src="https://cloud.githubusercontent.com/assets/674497/16192984/1121d222-370a-11e6-8da9-43adc80c9c15.png";>
    
    
    
    ### Questions:
    * Does the licenses files need update? no 
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1036

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1051.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1051
    
----
commit 2e8dc0c8253ceca1472bf431372204a2ed6bd8ee
Author: Prabhjyot Singh <prabhjyotsi...@gmail.com>
Date:   2016-06-20T11:25:27Z

    increase more logs, and return appropriate error to front-end

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---