GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/1047
[ TEST ] Selenium test modified according to Shiro failed the test.
### What is this PR for?
Shiro web test is included as an element of Selenium web test.
However, Shiro test case is to restart the zeppelin server.
As a result, the Selenium test does not work properly.
- Shiro modified to proceed to the last test.
```java
public class AuthenticationIT extends AbstractZeppelinIT {
@BeforeClass
public static void startUp() {
if (!endToEndTestEnabled()) {
return;
}
try {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
File file = new File(conf.getShiroPath());
originalShiro = StringUtils.join(FileUtils.readLines(file, "UTF-8"),
"\n");
FileUtils.write(file, authShiro, "UTF-8");
} catch (IOException e) {
LOG.error("Error in AuthenticationIT startUp::", e);
}
ZeppelinITUtils.restartZeppelin(); // <---- restart
driver = WebDriverManager.getWebDriver();
}
@AfterClass
public static void tearDown() {
if (!endToEndTestEnabled()) {
return;
}
try {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
File file = new File(conf.getShiroPath());
FileUtils.write(file, originalShiro, "UTF-8");
} catch (IOException e) {
LOG.error("Error in AuthenticationIT tearDown::", e);
}
ZeppelinITUtils.restartZeppelin(); // <----- restart
driver.quit();
}
}
```
### What type of PR is it?
Bug Fix
### Todos
- [x] added plugin (maven-surefire) in zeppelin-server pom.
- [x] modified class name
(AuthenticationIT.java -> ZeppelinShiroAuthenticationIT.java) -fixed
last test
### How should this be tested?
this is a travis result issue.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin
cifail/selenium-testfailed-via-auth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1047.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1047
----
commit c0b0dd2aa752f6abed8bed8ddc7bbff66eabb480
Author: CloverHearts <cloverhearts...@gmail.com>
Date: 2016-06-20T05:18:27Z
Selenium test modified according to Shiro failed the test.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
