GitHub user jongyoul opened a pull request:

    https://github.com/apache/zeppelin/pull/1035

    [MINOR] Changed guava version to 19.0 for selenium test

    ### What is this PR for?
    Enable selenium test with SafariDriver.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [x] - Upgrade guava version
    
    ### What is the Jira issue?
    N/A
    
    ### How should this be tested?
    1. Install selenium driver for Safari
    1. Make sure that you don't have firefox installed
    1. Start Zeppelin without this patch
    1. run a selenium test. `TEST_SELENIUM="true" mvn package 
-DfailIfNoTests=false -pl 
'zeppelin-interpreter,zeppelin-zengine,zeppelin-server' 
-Dtest=ParagraphActionsIT`
    1. Got error
    1. Repeat after patch
    1. Success
    
    ### Screenshots (if appropriate)
    Got error like:
    ```
    java.lang.NoSuchMethodError: 
com.google.common.util.concurrent.MoreExecutors.directExecutor()Ljava/util/concurrent/Executor;
        at 
org.openqa.selenium.safari.WebSocketConnection.send(WebSocketConnection.java:139)
        at 
org.openqa.selenium.safari.SafariDriverCommandExecutor.execute(SafariDriverCommandExecutor.java:188)
        at 
org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:620)
        at 
org.openqa.selenium.remote.RemoteWebDriver.startSession(RemoteWebDriver.java:247)
        at 
org.openqa.selenium.remote.RemoteWebDriver.<init>(RemoteWebDriver.java:129)
        at 
org.openqa.selenium.remote.RemoteWebDriver.<init>(RemoteWebDriver.java:142)
        at org.openqa.selenium.safari.SafariDriver.<init>(SafariDriver.java:62)
        at org.openqa.selenium.safari.SafariDriver.<init>(SafariDriver.java:42)
        at 
org.apache.zeppelin.WebDriverManager.getWebDriver(WebDriverManager.java:103)
        at 
org.apache.zeppelin.integration.ParagraphActionsIT.startUp(ParagraphActionsIT.java:51)
    ```
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jongyoul/zeppelin 
minor-upgrade-guava-for-selenium-with-safaridriver

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1035.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1035
    
----
commit 6f932789d84fb313d2865067d946dc51e9fd3d1d
Author: Jongyoul Lee <jongy...@gmail.com>
Date:   2016-06-17T08:33:49Z

    Changed guava version to 19.0

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to