GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/993

    [ZEPPELIN-987] Enable user to secure interpreter setting, credentials and 
configurations info

    ### What is this PR for?
    For some user case, people might want to hide **Interpreter Setting**, 
**Credentials** and **Configurations** information to other users (who are 
defined in `conf/shiro.ini`). So I added 
    
    ```
    #/api/interpreter/** = authc, roles[admin]
    #/api/configurations/** = authc, roles[admin]
    #/api/credential/** = authc, roles[admin]
    ``` 
    below the [ [urls] 
](https://github.com/apache/zeppelin/blob/master/conf/shiro.ini#L38) section. 
    
    This issue was originally suggested in [Zeppelin user mailing 
list](https://mail-archives.apache.org/mod_mbox/zeppelin-users/201606.mbox/%3CCAPgU7Y%3DBJrXQ_P0ond4PTukoya0FEjwoPuUb31iN3qwo8iyM1Q%40mail.gmail.com%3E)
 by @TomNorden
    
    
    ### What type of PR is it?
    Improvement | Documentation
    
    ### Todos
    * [x] - Add `interpreter`, `credential` and `configuration` url to 
`conf/shiro.ini`
    * [x] - Update `shiroauthentication.md` for this change
    
    ### What is the Jira issue?
    [ZEPPELIN-987](https://issues.apache.org/jira/browse/ZEPPELIN-987)
    
    ### How should this be tested?
    1. Apply this patch and restart Zeppelin
    2. Login with `admin` and `password1`
    3. Go to interpreter, credential and configuration tab -> You can see all 
of the information in each tabs 
    4. Logout -> Login again with `user1` and `password2`
    5. Go to interpreter, credential and configuration tab -> In this time, you 
can't see all of the information in each tabs 
    
    ### Screenshots (if appropriate)
    - When you login with `user1` (doesn't have permission to see the 
interpreter, credential and cofiguration info)
    
![shiro](https://cloud.githubusercontent.com/assets/10060731/15976943/9bbdc100-2f0a-11e6-884c-379449c7b5a2.gif)
    
    - `shiroauthentication.md`
    <img width="807" alt="screen shot 2016-06-10 at 12 25 02 pm" 
src="https://cloud.githubusercontent.com/assets/10060731/15976949/a49bc542-2f0a-11e6-8869-8575ba8f1875.png";>
    
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes, so I updated. 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-987

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/993.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #993
    
----
commit c42c927e4f1c2aeb4630e28b6e47a7b54879da01
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2016-06-10T19:36:42Z

    Change authcBasic -> authc

commit 57cfe3616244a985cdb25babd72640cc51c9dea0
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2016-06-10T19:37:12Z

    Update shiro authentication docs

commit 3238c7540a7d7ea28eae00e33f1300481130a396
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2016-06-10T19:41:15Z

    Add interpreter, credential and configuration urls to shiro.ini

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to