GitHub user ravicodder opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/937
Auto-suggestion feature for notebook permissions
### What is this PR for?
This PR will provide user-friendly way to give notebook permissions. It
will show suggestions on the basis of usernames matching the input characters.
It will communicate with Shiro to fetch usernames from the configured
realms and select usernames matching the input character and shows it to the
user as suggestions.
Currently, it works with shiro.ini file, LDAP, JDBC. In future we can
extend it to work with other realms too.
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
### How should this be tested?
1. Authenticate Zeppelin with any of the realms mention above(LDAP,
JDBC,ini).
2. In notebook permission section, try giving permissions to some notebook
and press some initial characters . It should show matching users as
suggestions and you should be able to select users from the suggestions.
3. You should be able to give usernames separated by comma and finally save
it.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?no
* Is there breaking changes for older versions?no
* Does this needs documentation?maybe
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravicodder/incubator-zeppelin auto-suggestion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/937.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #937
----
commit 060f27a38f6620709e19f821dfca23c02b055d8f
Author: Ravi Ranjan <[email protected]>
Date: 2016-04-04T07:36:50Z
add auto-suggest option
commit ef3658c92c704057b5e4e2ec26c34e9c000b5366
Author: Ravi Ranjan <[email protected]>
Date: 2016-04-04T09:07:07Z
add GetUserList.java file
commit 80ace5f5e6b7dbb364f3b303febea2a92e25eeec
Author: Prabhjyot Singh <[email protected]>
Date: 2016-04-04T09:33:48Z
aa
commit cdc50b35a45fd223206a0959bf7e36b796c923d7
Author: Ravi Ranjan <[email protected]>
Date: 2016-04-07T10:38:24Z
Modified notbook.html , include alert on save, modify condition to
identify the realm
commit 6627019c897218044c4de29c6b70393cd80e7496
Author: Ravi Ranjan <[email protected]>
Date: 2016-05-19T08:21:31Z
Merge branch 'master' of https://github.com/apache/incubator-zeppelin into
auto-suggestion
Conflicts:
zeppelin-web/src/app/notebook/notebook.controller.js
commit 140af6969b1e5ee3bd8c20a8c8a8bfd827372ff6
Author: Ravi Ranjan <[email protected]>
Date: 2016-05-31T09:05:13Z
Merge branch 'master' of https://github.com/apache/incubator-zeppelin into
auto-suggestion
commit 6194b9c6464d685653c2fc387144c84f0f32153e
Author: Ravi Ranjan <[email protected]>
Date: 2016-05-31T09:49:19Z
change codeing style
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
