Wilfred Spiegelenburg created YUNIKORN-1561:
-----------------------------------------------
Summary: make lint should pass when there are no go file changes
Key: YUNIKORN-1561
URL: https://issues.apache.org/jira/browse/YUNIKORN-1561
Project: Apache YuniKorn
Issue Type: Improvement
Components: core - common, shim - kubernetes
Reporter: Wilfred Spiegelenburg
If we have no changes in go files at all the make lint check fails:
{code:java}
Run make lint
4curl -sSfL
https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh
-s -- -b /home/runner/go/bin v1.50.1
5golangci/golangci-lint info checking GitHub for tag 'v1.50.1'
6golangci/golangci-lint info found version: 1.50.1 for v1.50.1/linux/amd64
7golangci/golangci-lint info installed /home/runner/go/bin/golangci-lint
8stat /home/runner/go/bin/golangci-lint > /dev/null 2>&1
9running golangci-lint
10git symbolic-ref -q HEAD && REV="origin/HEAD" || REV="HEAD^" ; \
11headSHA=$(git rev-parse --short=12 ${REV}) ; \
12echo "checking against commit sha ${headSHA}" ; \
13/home/runner/go/bin/golangci-lint run --new-from-rev=${headSHA}
14checking against commit sha a9cdd44d9785
15level=error msg="Running error: context loading failed: no go files to
analyze"
16make: *** [Makefile:121: lint] Error 5
17Error: Process completed with exit code 2. {code}
A return code of 5
[NoGoFiles|https://github.com/golangci/golangci-lint/blob/master/pkg/exitcodes/exitcodes.go]
should be eaten and still give a success
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
