June 20, 2022 11:51 AM, "Weiwei Yang" <[email protected]> wrote:
> We used to have GitHub action to auto-build and push "latest" images for > the convenience of test & dev > but I guess that was removed a long time ago. Still worth checking if > anywhere still uses "latest" images. > For e2e tests, IIRC, we are pulling > the source code and building the docker images locally on the testing VM, > it probably won't break. That's true for the shim itself, but NOT for the web UI. The shim e2e tests use the "latest" tag for the web UI. > On Mon, Jun 20, 2022 at 6:27 AM Craig Condit <[email protected]> wrote: > >> We need to be careful about how we do this, as it will cause breakage. Off >> the top of my head, e2e tests for the shim will definitely break, as they >> will be unable to deploy the web UI successfully if the web:latest tag goes >> away. There may be others as well… >> >> - Craig >> >> On Jun 19, 2022, at 8:32 PM, Wilfred Spiegelenburg <[email protected]> >> wrote: >> >> On docker hub we publish images with the tag "latest". According to >> the Apache release policy we can release compiled packages as part of >> our release. The artifacts have to comply with a couple of simple >> rules [1]. An image with the "latest" tag does not comply with these >> rules as it does not have the same version number as the source >> release. >> >> We should clean up the docker hub and remove the "latest" tags [2]. >> Before we make that change we should add a note to the Readme on the >> docker hub to show what we publish. After a short grace period we can >> then remove the latest tag. A good point would be to have that >> coincide with the next release for YuniKorn. >> >> Wilfred >> >> [1] https://www.apache.org/legal/release-policy.html#compiled-packages >> [2] https://hub.docker.com/r/apache/yunikorn/tags?page=1&name=latest >> [3] https://hub.docker.com/repository/docker/apache/yunikorn >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
