potiuk commented on issue #280: URL: https://github.com/apache/whimsy/issues/280#issuecomment-3468674127
> Agreed, but to fix it properly there needs to be a reference to the official policy Well the policy is quite clear, I think it's whimsy check that it's wrong: > This page contains HTML examples for injecting banners for current Apache events into a project web site. All Apache project websites SHOULD have a link to upcoming events, and this is the preferred way of doing that. The policy says (very clearly) that the pages shoudl contain link to upcoming events. And that the banners are preferred (but only preferred). So - as I see it, regexp for `events.apache.org" check fulfills the ` SHOULD have a link to upcoming events`. The "preferred" part is clearly optional (unless I misunderstand what "preferred" word means". That's why I believe whimsy descriptin of the error and regexp explained as "way of checking" it is correct and whimsy should do what it explains it's doing. There is an inconsistency here - because despite matching the regular expression and actually the airflow.apache.org "having a link to upcoming events" (it does as policy explains) whimsy flags it as an error - so something is wrong (possibly a technical issue) with the check in whimsy. Would you agree with this way of explaining it - and if not - which part of it? So my suggestion is to make the check follow the existing policy where the only SHOULD is about having link, rather than expecting the "preferred" way of doing it. Would you agree with it? Or you would like to propose other solution? I think all three things are clear: 1) policy expects a link and suggest a way how the link could be done 2) whimsy error description seems to agree with that but 3) there is apparently an error with implementing 2) that produces red status So my proposal is to find and fix the technical issue. Is there some flaw or misunderstanding in this proposal ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
