Discussing PR263, I wondered how and where Whimsy makes assumptions
about names; these are some partial notes that may be helpful.
Most of the "do the obvious thing" URLs or functions work nicely, but
some make default choices between first name, ID, or a person's public
name (as expressed in ASF::Person) for historical reasons.
- The URL for individual shepherd queues is first name:
https://github.com/apache/whimsy/blob/28661ee09651f5945f479bd2bc1ff19d5add5f29/www/board/agenda/routes.rb#L69
- And new agendas default to shepherd first name:
https://github.com/apache/whimsy/blob/28661ee09651f5945f479bd2bc1ff19d5add5f29/lib/whimsy/asf/board.rb#L120
And there may be other instances that default similarly.
board.rb also has a historical DIRECTOR_MAP, which is mostly used when
scanning data to map any potential old comment markers that are
initials, first names, or full names back to an ASF ID.
- Whimsy uses websockets to attempt to push live updates between all
current session users, and uses both userid (from login session),
username, first name (used in some display contexts), and initials
(historically used as the default for adding comments to agenda), which
is cached on the server in AGENDA_WORK
https://github.com/apache/whimsy/blob/28661ee09651f5945f479bd2bc1ff19d5add5f29/www/board/agenda/routes.rb#L240
- Some session based caches in AGENDA_WORK expire after 2 days, so I
wonder if this occasionally feels like a bug if there's some setting
(like default string used to mark comments) seems to change after time?
https://github.com/apache/whimsy/blob/master/www/board/agenda/daemon/session.rb
--
- Shane
Member
The Apache Software Foundation
