[
https://issues.apache.org/jira/browse/WHIMSY-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923363#comment-17923363
]
Shane Curcuru commented on WHIMSY-425:
--------------------------------------
In particular, for any display purposes, we should never stop the script with
an error, only somehow annotate that entry with a warning of possibly incorrect
data, and then dump what we found.
In the short term, any scripts that write data back must ensure we never lose
nomination chunks, even if we don't think we can parse a block, we should
consider simply re-dumping the block as-is text chunk, or in that case, fail,
with an informative error message.
> member-files.rb throws error for minor parsing issues
> -----------------------------------------------------
>
> Key: WHIMSY-425
> URL: https://issues.apache.org/jira/browse/WHIMSY-425
> Project: Whimsy
> Issue Type: Bug
> Reporter: Shane Curcuru
> Priority: Major
>
> For manually added nominations, there are two current failure cases causing
> issues:
> * When a Member name is misspelled or different than public_name,
> check_boardnoms.cgi shows ?? as their highlighted name. Whatever parsing is
> done here should attempt to do close-enough matching, or otherwise provide a
> specific hint as to how to fix the specific data file.
> * When a nomination has minor formatting errors like:
> ** Nominated by [f...@apache.org|mailto:f...@apache.org]
> * member-files.rb:99 throws the ArgumentError, thus breaking the rest of the
> output of the script. For scripts like check_boardnoms.cgi, they should
> avoid failing, and instead always produce as much output as possible,
> annotating any data that might not be formatted exactly.
> I'm going to start working on making the scripts at least not error and stop,
> but rather annotate individual parts of output and continue.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
