On Fri, 24 Jan 2025 at 20:01, <curc...@apache.org> wrote: > > This is an automated email from the ASF dual-hosted git repository. > > curcuru pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/whimsy.git > > > The following commit(s) were added to refs/heads/master by this push: > new 0c4fc733 PRovide a message on fail > 0c4fc733 is described below > > commit 0c4fc73321b38d0e6c7233a3d90f01831c9afb0c > Author: Shane Curcuru <a...@shanecurcuru.org> > AuthorDate: Fri Jan 24 14:59:39 2025 -0500 > > PRovide a message on fail > --- > lib/whimsy/asf/meeting-util.rb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/whimsy/asf/meeting-util.rb b/lib/whimsy/asf/meeting-util.rb > index b3528d1b..1b5a796e 100644 > --- a/lib/whimsy/asf/meeting-util.rb > +++ b/lib/whimsy/asf/meeting-util.rb > @@ -176,12 +176,12 @@ module ASF > end > > # Read runbook/timeline.json file, not present before 2025 > - # @return hash, or null if not found > + # @return hash, or string error if not found > def self.get_timeline(mtg_root) > begin > return JSON.parse(IO.read(File.join(mtg_root, 'runbook', > 'timeline.json'))) > rescue StandardError => e > - return null > + return "ERROR: get_timeline(#{mtg_root}) threw: #{e.message}"
I don't see any checks on the return type by callers of this routine. AFAICT they all assume it is a hash. > end > end > >
