On Sat, 3 Aug 2024 at 02:51, Craig Russell <apache....@gmail.com> wrote:
>
> I would  like to add some more paragraphs to both accept and reject messages.
>
> Currently, there are three files that need to be kept in sync. I would like 
> to reorganize these so that only one file needs to be updated to generate:

Which 3 files are these?
I could only find incomplete.json.rb and parts.js.rb

> the short prompt in the workbench, e.g. "invalid public name"
> the paragraph to the user, e.g. "- the public name should be a real name or 
> pen name and not a user id"
>
> I'm proposing to add a file with all of the labels, short prompts, and 
> paragraphs. Then the PR simply needs to update the file and voilá.

It would be trivial to change incomplete.json.rb to read its data from a file.
AFAICT it would not be easy to update parts.js.rb. Note that this is
converted into JavaScript from Ruby and not all Ruby facilities are
available.
It might end up being very hard to follow/maintain.

> Any ideas for the name of the file, and whether it should be simply a 
> comma-separated raw text file or something with more structure?

If it is possible, then I think the file needs to be something
structured like YAML.

> invpub, invalid public name, the public name should be a real name or pen 
> name and not a user id
>
> or
>
> ["invpub", "invalid public name", "the public name should be a real name or 
> pen name and not a user id"]
>
> How to tell whether the messages are applicable to the accept or reject 
> process? Maybe two different files?
>
> WDYT?

I think it will be a lot of work.

> Craig L Russell
> c...@apache.org
>

Reply via email to