On Tue, 26 Sept 2023 at 21:59, <mattsic...@apache.org> wrote: > > This is an automated email from the ASF dual-hosted git repository. > > mattsicker pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/whimsy.git > > > The following commit(s) were added to refs/heads/master by this push: > new 5e47f5a9 Add pen name option to rejection template > 5e47f5a9 is described below > > commit 5e47f5a97fe987dc542737f795263472092c7a82 > Author: Matt Sicker <boa...@gmail.com> > AuthorDate: Tue Sep 26 15:58:19 2023 -0500 > > Add pen name option to rejection template > > Since we've clarified that pen names are allowed for public names, this > updates the template used for rejecting invalid use of public names to > indicate that. > --- > www/secretary/workbench/views/actions/incomplete.json.rb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/secretary/workbench/views/actions/incomplete.json.rb > b/www/secretary/workbench/views/actions/incomplete.json.rb > index 61f33611..ee4252e3 100644 > --- a/www/secretary/workbench/views/actions/incomplete.json.rb > +++ b/www/secretary/workbench/views/actions/incomplete.json.rb > @@ -16,7 +16,7 @@ REASONS = { > '@missing_address' => 'missing or incomplete postal address', > '@missing_email' => 'missing email address', > '@corporate_postal' => 'the postal address does not appear to be a > personal postal address', > - '@invalid_public' => 'the public name should be a real name and not a user > id', > + '@invalid_public' => 'the public name should be a real name or pen name > and not a user id',
Is there a reason why we disallow user ids for public names? It does not make sense to me to discriminate on that basis. > '@separate_signature' => 'the document and signature must be sent attached > to the same email', > '@unauthorized_signature' => 'the signature must be from an authorized > person, usually a company executive', > '@empty_form' => 'the form appears to be completely empty', >
