sebbASF commented on a change in pull request #142: URL: https://github.com/apache/whimsy/pull/142#discussion_r838337234
########## File path: www/secretary/workbench/views/actions/incomplete.json.rb ########## @@ -23,6 +23,7 @@ '@unreadable_scan' => 'the scan is not readable or not complete', '@wrong_identity' => 'the public key does not match the name/email on the form', '@validation_failed' => 'gpg validation failed', + '@signature_not_armored' => 'gpg signature_not_armored', Review comment: The text on the RHS is sent to the user, and the sample above is not exactly clear... also it's not just that the sig must be ASCII-armoured: we also need a detached signature, i.e. not a file with the signature appended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@whimsical.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org