clr-apache commented on pull request #133: URL: https://github.com/apache/whimsy/pull/133#issuecomment-1046134468
Ok, I fixed these but not sure where the changes ended up. I had trouble committing to parts.js.rb... Craig > On Feb 19, 2022, at 4:41 PM, sebbASF ***@***.***> wrote: > > > @sebbASF requested changes on this pull request. > > In www/secretary/workbench/views/actions/incomplete.json.rb <https://github.com/apache/whimsy/pull/133#discussion_r810553377>: > > > @@ -15,6 +15,14 @@ > REASONS = { > ***@***.***_address' => 'missing or incomplete postal address', > ***@***.***_email' => 'missing email address', > + '@@corporate_postal' => 'the postal address does not appear to be a personal postal address', > @@ => @ > > In www/secretary/workbench/views/parts.js.rb <https://github.com/apache/whimsy/pull/133#discussion_r810553463>: > > > @@ -204,7 +220,7 @@ def render > _label do > _input type: 'radio', name: 'doctype', value: 'incomplete', > onClick: self.reject > - _span 'incomplete form (select missing items below first)' > + _span 'incomplete form (problematic items below)' > Strictly speaking this is now not just for incomplete forms > > — > Reply to this email directly, view it on GitHub <https://github.com/apache/whimsy/pull/133#pullrequestreview-887978325>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4M6RGCSHYEG53RVUHSW2LU4A2EXANCNFSM5O3TOHLA>. > Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > You are receiving this because you authored the thread. > Craig L Russell ***@***.*** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@whimsical.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
